[PATCH] Make checkpatch rant about trailing ; at the end of "if"expr

From: Eugene Teo
Date: Thu Aug 16 2007 - 02:17:45 EST


Make checkpatch rant about trailing ; at the end of "if" expression.

Thanks to Auke for the regexp.

Signed-off by: Eugene Teo <eugeneteo@xxxxxxxxx>

--- checkpatch.pl-0.09.default 2007-08-03 23:31:40.000000000 +0800
+++ checkpatch.pl-0.09 2007-08-16 13:18:40.000000000 +0800
@@ -1091,6 +1091,12 @@ sub process {
CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
}
}
+
+# checks for trailing ; at the end of "if" expression
+ if ($line =~ /\bif\s*\([^\)]*\)\s*\;/) {
+ my $herevet = "$here\n" . cat_vet($line) . "\n";
+ ERROR("trailing ;\n" . $herevet);
+ }
}

if ($chk_patch && !$is_patch) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/