Re: refcounting problems with ibm_acpi but acpi=off

From: Henrique de Moraes Holschuh
Date: Tue Aug 07 2007 - 19:55:55 EST


On Tue, 07 Aug 2007, Pavel Machek wrote:
> > > --- a/drivers/acpi/ibm_acpi.c
> > > +++ b/drivers/acpi/ibm_acpi.c
> > > @@ -2695,6 +2695,9 @@ static void acpi_ibm_exit(void)
> > > {
> > > int i;
> > >
> > > + if (acpi_disabled)
> > > + return;
> > > +
> > > for (i = ARRAY_SIZE(ibms) - 1; i >= 0; i--)
> > > ibm_exit(&ibms[i]);
> > >
> > >
> >
> > Indeed it is required, my bad.
> >
> > Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> >
> > Do you want me to forward a git patch to Len brown?
>
> Yes, please. Hmm, seems like at least asus_acpi is affected by same problem.

I just tested it, and thinkpad-acpi with all accepted patches by Len is not
affected by this problem, only some versions of ibm-acpi is. So there's
nothing to send to Len.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/