Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

From: Serge E. Hallyn
Date: Tue Aug 07 2007 - 11:19:59 EST


Quoting James Morris (jmorris@xxxxxxxxx):
> On Tue, 7 Aug 2007, Serge E. Hallyn wrote:
>
> > Shall I resend without the LSM_NEED_LOCK, or do you still want a more
> > fundamental change?
>
>
> Removing the needlock is enough, the rest was just a query/suggestion.

Ok - I'll explictly lock the i_mutex in
fs/splice.c:generic_file_splice_write(). The ugliness there is that
the mutex will always be taken - even if there is no xattr to be
removed or even if CONFIG_SECURITY=n.

I guess I'll do some perf runs and see what kind of impact that has.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/