Re: [NFS] 2.6.23-rc1-mm2

From: Johannes Berg
Date: Mon Aug 06 2007 - 06:57:30 EST


On Mon, 2007-08-06 at 14:53 +0400, Oleg Nesterov wrote:

> But this makes ->lockdep_map meaningless? We always take wq->lockdep_map
> for reading, now we can't detect deadlocks.
>
> read_lock(A);
> lock(B);
>
> vs
> lock(B);
> read_lock(A);
>
> is valid, kernel/lockdep.c should not complain.

Ah, hmm. Good point, I guess you can always have multiple read locks.
Then we'd have to make a new parameter or such to get rid of the
recursive locking try message. But if you want to deprecate the API
anyway then this is a good way to find it.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part