Re: [patch (take 2)] genirq: fix simple and fasteoi irq handlers

From: Ingo Molnar
Date: Mon Aug 06 2007 - 02:15:24 EST



* Jarek Poplawski <jarkao2@xxxxx> wrote:

> Subject: genirq: fix simple and fasteoi irq handlers
>
> After the "genirq: do not mask interrupts by default" patch interrupts
> should be disabled not immediately upon request, but after they
> happen. But, handle_simple_irq() and handle_fasteoi_irq() can skip
> this once or more if an irq is just serviced (IRQ_INPROGRESS),
> possibly disrupting a driver's work.

nice fix. I think this is exactly the type of bug we were hoping to be
able to identify and fix, and it could explain the regression in its
entirety. The big question - does it fix Marcin's regression?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html