Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND andCONFIG_HIBERNATION

From: Linus Torvalds
Date: Fri Aug 03 2007 - 18:02:29 EST




On Fri, 3 Aug 2007, Rafael J. Wysocki wrote:
> depends on PM
> - depends on !SMP || SUSPEND_SMP_POSSIBLE
> + depends on SUSPEND_SMP_POSSIBLE || ((BLACKFIN || MIPS || SUPERH || FRV \
> + || (PPC32 && PPC_MPC52xx)) && !SMP)

Please, do that as SUSPEND_UP_POSSIBLE, and make it look like

config SUSPEND_UP_POSSIBLE
depends on BLACKFIN || MIPS || SUPERH || FRV || ((PPC32 && PPC_MPC52xx)
depends on !SMP
default y

and now you can write the above thing as

depends on SUSPEND_SMP_POSSIBLE || SUSPEND_UP_POSSIBLE

and it's all much nicer.

I would say that doing a similar setup for HIBERNATE would be nice too,
but the SUSPEND case is more noticeable because the SMP case is so nice
already.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/