Re: [PATCH] kill an obsolete sub-thread-ptrace stuff

[Roland McGrath]

> There is a couple of subtle checks which were needed to handle ptracing from
> the same thread group. This was deprecated a long ago, imho this code just
> complicates the understanding.

Looks ok to me.

> And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify()
> is not right. SIGNAL_GROUP_EXIT can mean exec(), not exit_group(). This means
> ptracer can lose a ptraced zombie on exec(). Minor problem, but still the bug.

This bug never happens because this check is only in the now-impossible
ptrace-same-group case.  The code can certainly go.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/