Re: [PATCH 44] drivers/scsi/lpfc/lpfc_debugfs.c: kmalloc + memsetconversion to kcalloc

From: James Smart
Date: Fri Aug 03 2007 - 11:42:58 EST


ACK

-- james s

Mariusz Kozlowski wrote:
Signed-off-by: Mariusz Kozlowski <m.kozlowski@xxxxxxxxxx>

drivers/scsi/lpfc/lpfc_debugfs.c | 13809 -> 13716 (-93 bytes)
drivers/scsi/lpfc/lpfc_debugfs.o | 146124 -> 146124 (0 bytes)

drivers/scsi/lpfc/lpfc_debugfs.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

--- linux-2.6.23-rc1-mm1-a/drivers/scsi/lpfc/lpfc_debugfs.c 2007-07-26 13:07:42.000000000 +0200
+++ linux-2.6.23-rc1-mm1-b/drivers/scsi/lpfc/lpfc_debugfs.c 2007-07-31 14:11:24.000000000 +0200
@@ -432,14 +432,11 @@ lpfc_debugfs_initialize(struct lpfc_vpor
if (!lpfc_debugfs_start_time)
lpfc_debugfs_start_time = jiffies;

- vport->disc_trc = kmalloc(
- (sizeof(struct lpfc_disc_trc) * lpfc_debugfs_max_disc_trc),
- GFP_KERNEL);
+ vport->disc_trc = kcalloc(lpfc_debugfs_max_disc_trc,
+ sizeof(struct lpfc_disc_trc), GFP_KERNEL);

if (!vport->disc_trc)
goto debug_failed;
- memset(vport->disc_trc, 0,
- (sizeof(struct lpfc_disc_trc) * lpfc_debugfs_max_disc_trc));

snprintf(name, sizeof(name), "discovery_trace");
vport->debug_disc_trc =

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/