Re: gcc fixed size char array initialization bug - known?

From: Guennadi Liakhovetski
Date: Thu Aug 02 2007 - 17:26:57 EST


On Thu, 2 Aug 2007, Al Viro wrote:

> On Thu, Aug 02, 2007 at 10:26:37PM +0200, Guennadi Liakhovetski wrote:
> >
> > Worse yet, K&R explicitely writes:
> >
> > <quote>
> >
> > char pattern[] = "ould";
> >
> > is a shorthand for the longer but equivalent
> >
> > char pattern[] = { 'o', 'u', 'l', 'd', '\0' };
> >
> > </quote>
> >
> > In the latter spelling gcc < 4.2 DOES warn too.
>
> Does warn for what? Array with known size? Sure, so it should - you
> have excess initializer list elements.
>
> Note the [] in the quoted - it does matter.
>
> Again, it's perfectly legitimate to use string literal to initialize
> any kind of array of character type. \0 goes there only if there's
> space for it; if array size is unknown, the space is left. That's it.

Sure. Doing 'char c[4] = "01234";' is just like doing '"0123"': only
those bytes, for which there's space in the array go in, everything makes
perfect sense. What doesn't make sense to me though, is that in the former
case gcc warns, but not in the latter.

Maybe you're right in your interpretation of the standard / K&R, but it
doesn't still make it logical to me, sorry. I always thought "0123" was 5
bytes long (ok, ascii) and the terminating '\0' was an integral part of
the string, no different from any other character, and not some optional
token. Thus all the charecters should be handled equally.

Thanks
Guennadi
---
Guennadi Liakhovetski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/