Re: [PATCH] FRV: Make BSG declarations dependent on CONFIG_BLOCK

From: James Bottomley
Date: Wed Aug 01 2007 - 13:30:34 EST


On Wed, 2007-08-01 at 15:44 +0100, David Howells wrote:
> James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:
>
> > Are you sure you're testing with git head? CONFIG_BLK_DEV_BSG cannot be
> > set unless CONFIG_BLOCK is (which was a bug in previous releases now
> > fixed in git head ... unless the fix has gone wrong?).
>
> Neither CONFIG_BLK_DEV_BSG nor CONFIG_BLOCK are set. The problem is that the
> stub BSG functions refer to undefined structures when CONFIG_BLOCK=n.

Hmm, then isn't the fix to add a struct request_queue; and other
definitions above the stub functions?

What is the file that's causing this actual problem ... as in what still
needs to pull in the block headers if CONFIG_BLOCK=n (or more properly,
could it also need to use the bsg stub functions?)

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/