Re: [PATCH] usbhid: add ASUS LCM to the blacklist

From: Chr
Date: Mon Jul 30 2007 - 10:11:21 EST


On Monday, 30. July 2007, Jiri Kosina wrote:
> On Fri, 27 Jul 2007, Christian Lamparter wrote:
>
> > Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is
> > attached to an internal USB bus. Unfortunatly the device reports a wrong
> > DeviceDescriptor and is therefore identified as a HID device...
>
> Hi Christian,
>
> I have slightly modified your patch (let's keep the hid_blacklist[]
> properly sorted) and applied it into my tree.

Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk type. "
But is there a Order for the bitfields? e.g

shouldn't: hid-quriks.c (line 439, 440)

{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI,
HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE }

be:
{..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }


Anyway, thanks for merging!
Chr.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/