Re: [1/2] 2.6.23-rc1: known regressions

[Richard Purdie]

On Mon, 2007-07-23 at 14:36 +0100, Al Viro wrote:
> On Mon, Jul 23, 2007 at 02:12:07PM +0100, Richard Purdie wrote:
> > Fix the leak where asus-led registration fails half way through.
>  
> Frankly, I don't think that any post-factum checks are needed.  We
> should just bail out at the point of failure.  See the patch posted
> earlier...  BTW, your variant does destroy_workqueue() when no
> create_singlethreaded_workqueue() had been called.  FWIW, here's
> the patch I'm talking about:

I saw that after I'd posted mine. I don't mind which we use... 

I'm pleased the IS_ERR(object##_led.class_dev) is gone as that makes
nasty assumptions about what the LED class does internally...

Cheers,

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/