Re: [RFC, Announce] Unified x86 architecture, arch/x86

From: Brian Gerst
Date: Sat Jul 21 2007 - 07:36:28 EST


Thomas Gleixner wrote:
> On Sat, 2007-07-21 at 07:37 +0200, Andi Kleen wrote:
>> On Saturday 21 July 2007 00:32, Thomas Gleixner wrote:
>>> As an initial matter, we made it painstakingly sure that the resulting
>>> .o files in a 32-bit build are bit for bit equal.
>> You got not a single line less code duplication then, so i don't really
>> see the point of this.
>
> Really ?
>
> The script detected 15 identical files with a simple cmp.
>
> It also unified another 10 by simply looking at the only line in there
> "include <the other arch/file>"
>
> And there is more of that, when you take the time and look closely at
> the _32.[ch] _64.[ch] files which are created by the merge.

Looking at the include files, many more are near-identical in trivial
ways, such as whitespace, comments, local variable names, or guard #ifdefs.

--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/