Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle

From: Matthew Wilcox
Date: Fri Jul 20 2007 - 13:08:31 EST


On Sun, Jul 15, 2007 at 10:53:45AM +0100, Simon Arlott wrote:
> Do people ever check what Lindent does?
[...]
> > -out1:
> > + out1:
>
> NAK: A perfectly valid non-indented label is now indented by 6 spaces.

I tracked down why indent does this. It's actually hard-coded to indent
by 2 fewer columns than the current code indentation. I've patched it
to allow specifying either an absolute column, or a column relative to
the current indentation level.

Patch here:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=433956

Of course, we can't add this flag to Lindent until it's widely
circulating amongst the distributions. Perhaps we can add this to
Lindent in the meantime:

sed -i -e 's/^\t* \(\w*:\)/ \1/' "$@"

which will replace the leading tabs and spaces with one space.
It should leave case labels unmolested, as they should be indented with
tabs, not 6 spaces.

Any regexp ninjas want to have a go at something better?

--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/