Re: kmalloc zero size changes break i386

From: Pekka Enberg
Date: Thu Jul 19 2007 - 15:03:48 EST


Linus Torvalds wrote:
Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is
totally broken.

The problem? It returns ZERO_SIZE_PTR from __find_general_cachep(), not from __kmalloc(). So anythign that uses __find_general_cachep() will get an invalid cachep pointer, which was not the point.
>
> Does something like this fix it?

I wondered about that too but I didn't spot any callers that would actually break. Andi? Roland?

Christoph, please go over this and see if there are other cases like that.

__do_kmalloc_node probably.


Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/