Re: new text patching for review

From: Jan Beulich
Date: Thu Jul 19 2007 - 08:26:19 EST


I like this approach much better, just one small note (I think I
had the same mistake in my changes initially):

>@@ -202,7 +209,7 @@ static void alternatives_smp_lock(u8 **s
> continue;
> if (*ptr > text_end)
> continue;
>- **ptr = 0xf0; /* lock prefix */
>+ text_poke(ptr, 0xf0); /* lock prefix */
> };
> }

You probably want *ptr here.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/