Re: [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

[H. Peter Anvin]

Andi Kleen wrote:
>>
>> No processors that support KVM exist that also do not support CMPXCHG64,
>> so no additional check is necessary.  This setup allows for a single kernel
>> that will boot on i486 and also support KVM if available.
> 
> The CONFIG should only control the early CPUID checks, which are needed for PAE
> kernels.
> 
> But for something late like KVM the correct fix is really to drop
> the ifdefs around the macro and check boot_cpu_has() yourself.
> 

He's checking for the appropriate functionality at runtime.  What this
does is makes it impossible to select KVM when you have already selected
a CPU that doesn't support CX8.

One can, of course, question the utility, since the CPU set that
supports KVM all support CX8, but not vice versa...

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/