Re: [PATCH] AFS: Fix file locking

[David Howells]

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> Here we use
> 
> 	vnode->flags & (1 << foo)
> 
> > +		set_bit(AFS_VNODE_LOCKING, &vnode->flags);
> 
> and elsewhere we use set_bit(foo, &vnode->flags) and clear_bit()

Ah...  IIRC I was originally testing multiple bits in one go (test_bit()'s do
not merge because of the volatile pointer).

However, as I'm doing only one test now, I'll convert it to test_bit().

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/