Re: [PATCH 1/3] drivers/base/core: improve device_add() error handling,fix bugs

From: Jeff Garzik
Date: Wed Jul 18 2007 - 05:00:33 EST


Cornelia Huck wrote:
On Wed, 18 Jul 2007 01:36:00 -0700,
Greg KH <greg@xxxxxxxxx> wrote:

Or it should be, hm, Cornelia, can you resend it, I seem to have dropped
it :(

Andrew just did :)

(For reference, here's the patch:)

From: akpm@xxxxxxxxxxxxxxxxxxxx
To: greg@xxxxxxxxx
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, cornelia.huck@xxxxxxxxxx
Subject: [patch 1/1] Driver core: check return code of sysfs_create_link()
Date: Wed, 18 Jul 2007 01:43:47 -0700

From: Cornelia Huck <cornelia.huck@xxxxxxxxxx>

Check for return value of sysfs_create_link() in device_add() and
device_rename(). Add helper functions device_add_class_symlinks() and
device_remove_class_symlinks() to make the code easier to read.

[akpm@xxxxxxxxxxxxxxxxxxxx: fix unused var warnings]
Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
Cc: Greg KH <greg@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

drivers/base/core.c | 145 ++++++++++++++++++++++++++++++------------
1 file changed, 105 insertions(+), 40 deletions(-)

ACK


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/