Re: regression: disk error loop (panic?) ide_do_rw_disk-bad:

From: Jens Axboe
Date: Wed Jul 18 2007 - 04:10:21 EST


On Tue, Jul 17 2007, Linus Torvalds wrote:
>
>
> On Wed, 18 Jul 2007, Bartlomiej Zolnierkiewicz wrote:
> >
> > The new generic SG layer is CONFIG_SCSI=y "generic" in the current tree.
>
> Yeah. I know, I already talked to Jens about it - in order to be generic,
> the BSG stuff really does end up having to be able to stand on its own,
> since not everybody wants/needs the whole SCSI layer.

Fully agree!

> > > obviously the older SCSI-ioctl layer) it should "just work".
> >
> > Agreed but IDE driver has never claimed to have full SAT layer and
> > full SCSI-ioctl layer support has been provided only for ide-cd.
>
> I agree, and understand why it happened, but hope that maybe it can be
> improved in the future, or at least the error returned earlier so that the
> request will never even hit the ATA device at all if the IDE layer cannot
> then handle it.
>
> > For now it should be sufficient to revert ide.c chunks of
> >
> > commit 3d6392cfbd7dc11f23058e3493683afab4ac13a3
>
> Jens?

Yep, those were probably a little over eager. I can see that this revert
has already been executed, so perfect.

Yep, those were probably a little over eager. I can see that this revert
has already been executed, so perfect.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/