Re: [PATCH] splice: fix wrong __splice_from_pipe() usage

From: Jens Axboe
Date: Mon Jul 16 2007 - 02:35:39 EST


On Mon, Jul 16 2007, OGAWA Hirofumi wrote:
> Hi,
>
> I've noticed the nfsd read corruption by recent change. And this patch
> fixes the problem for me, is this right fix?
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
>
>
> __splice_from_pipe() is updating the sd->pos for the actor, but those
> functions are passing the sd of reader side directory. So, splice
> updates sd->pos twice.
>
> This fixes usage of __splice_from_pipe().

For sendfile() usage, or the nfsd path that uses splice to send?

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/