Re: [RFT][PATCH v7] sata_mv: convert to new EH

From: Jeff Garzik
Date: Thu Jul 12 2007 - 15:04:44 EST


dean gaudet wrote:
On Thu, 12 Jul 2007, Jeff Garzik wrote:

dean gaudet wrote:
oh very nice... no warnings on boot, and no warnings while i "dd if=/dev/sdX
of=/dev/null" and i'm seeing 74MB/s+ from each disk on this simple read
test.

for lack of a better test i started an untar/diff stress test on the
disks... we'll see how it goes. (it's based on doug ledford's memtest.sh)
Thanks for the testing. Looks like we might have hit on something good...

yep this does look good. no problems overnight in the untar/diff/rm workload. if you've got any other workload you'd like me to throw at it, let me know. i might be able to scare up a disk or two with errors to check error handling.

Nothing specific. I usually just throw various workloads at it, both throughput-intensive, seek-intensive, multiple threads at the same time, stressing multiple disks at the same time, etc.

I presume from your past messages your tests include multiple disks at the same time?


i tested hotplug just for kicks... no luck there :) but then you didn't say that would work yet.

hehehe Well I sorta didn't want to mention it, to avoid clouding the waters further.

In theory, hotplug and hot unplug -should- work, in version 7. Your report is a useful contradiction of that theory, and signals where to poke next. Since all this hacking is a spare-time effort, so promises as to when next I'll poke at it. It might be tomorrow, or a month from now. Getting "new EH" upstream was a big hurdle to overcome, and your testing really helped that along.

Anyway, something like Version 7 is probably what I will push upstream for 2.6.23-rc1.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/