Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfigurationusing configfs

[Satyam Sharma]

Hi Keiichi,

On Sun, 8 Jul 2007, KII Keiichi wrote:
> Hi Satyam,
> 
> > After more discussion, Joel suggested the idea to separately manage the
> > lifetimes of the two kinds of netconsole_target objects, those created while
> > parsing boot/module options and those created via configfs mkdir(2) from
> > userspace, in my driver itself. That adds a little bit of complexity and
> > redundancy (multiple item creation and destruction points) in this driver.
> > Note that the latter type (configfs-created netconsole_targets) can be
> > modified / updated / destroyed at runtime from userspace but the former
> > (param string created) cannot, as they are not exposed through our configfs
> > namespace. However, this is not really a problem and is similar to current
> > behaviour in any case.
> 
> Maybe you should add the above description into 
> Documentation/networking/netconsole.txt.
> The users of netconsole applied these patches may think that they can change 
> parameters of netconsole_target(param string created at the time of parsing 
> boot/options).

Yes, you're absolutely right. This definitely needs to be mentioned in the
documenation -- I'll take care of this in the next iteration.

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/