Re: [linux-pm] Re: [PATCH] Remove process freezer from suspend to RAM pathway

From: Pavel Machek
Date: Sat Jul 07 2007 - 08:19:46 EST


On Fri 2007-07-06 09:07:38, Miklos Szeredi wrote:
> > > Actually fuse allows SIGKILL, because it's always fatal, and the
> > > syscall may not be restarted.
> >
> > Okay, and you should handle refrigerator in the same paths where you
> > handle SIGKILL. Just add try_to_freeze() there...
>
> It's the fourth time I'm repeating this in this thread:
>
> Yes adding try_to_freeze() there would partially solve the probelem.
>
> But another task can be sleeping on a mutex held by the task waiting
> for the reply. And the freezer won't be able to handle that one.
>
> Generally, calling try_to_freeze() with mutexes held is not a good
> idea.

Agreed, calling try_to_freeze() with mutex held is no-no, and it is
even documented somewhere.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/