Re: [PATCH -mm 5/9] netconsole: Introduce dev_status member

[Satyam Sharma]

Hi Stephen,

On Thu, 5 Jul 2007, Stephen Hemminger wrote:
> On Wed, 4 Jul 2007 08:56:42 -0500
> Matt Mackall <mpm@xxxxxxxxxxx> wrote:
> [...]
> > > +	if (nt->dev_status) {
> > 
> > Why not simply call net_dev_is_up?
> 
> The flags field values are really BSD legacy-ish stuff and should not be
> used internally. IFF_UP etc, do not have the necessary atomic properties.
> 
> Use netif_running() instead.

Ok, thanks for letting me know about that. I'll make the change.

Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/