Re: [patch 0/3] clean gendisk out of scsi ULD structs

From: Al Viro
Date: Thu Jul 05 2007 - 19:03:17 EST


On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote:
> Since gendisk will now become part of struct scsi_device, we don't need
> to store this value in any private data structs where they already store
> scsi_device. This series cleans up a few drivers which did this.

What the hell? gendisks are *NOT* supposed to be embedded into other
data structures, you'll screw up the lifetime rules for them.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/