Re: [PATCH] Optional Beeping During Resume From Suspend To Ram.

From: Rafael J. Wysocki
Date: Thu Jul 05 2007 - 14:56:17 EST


On Thursday, 5 July 2007 00:46, Pavel Machek wrote:
> Hi!
>
> > > Here's the version that uses just one variable, relative to Nigel's
> > > patch. Hmm, and it also closes nasty trap for the user in
> > > acpi_sleep_setup; order of parameters actually mattered there,
> > > acpi_sleep=s3_bios,s3_mode doing something different from
> > > acpi_sleep=s3_mode,s3_bios . It actually works here.
> > >
> > > Will you fold it into patch28, or should I create a changelog?
> >
> > Hmm, I think we should keep the record straight. Please add a changelog
> > if that's not a problem.
>
> (I also added documentation and removed the superfluous beep_flags).

OK, thanks.

Added to the patchset as

http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc7/patches/50-Optional-Beeping-During-Resume-From-Suspend-To-Ram-tidy.patch

I think both patches are -mm-ready, aren't they?

Greetings,
Rafael


--
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/