Re: [PATCH] Re: [NETPOLL] netconsole: fix soft lockup whenremoving module

[David Miller]

From: Jarek Poplawski <jarkao2@xxxxx>
Date: Wed, 4 Jul 2007 08:41:59 +0200

> On Mon, Jul 02, 2007 at 09:52:26AM +0200, Jarek Poplawski wrote:
> > 
> > From my recent patch:
> > 
> > > >    #1
> > > >    Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
> > > >    required a work function should always (unconditionally) rearm with
> > > >    delay > 0 - otherwise it would endlessly loop. This patch replaces
> > > >    this function with cancel_delayed_work(). Later kernel versions don't
> > > >    require this, so here it's only for uniformity.
> > 
> > But Oleg Nesterov <oleg@xxxxxxxxxx> found:
> > 
> > > But 2.6.22 doesn't need this change, why it was merged?
> > > 
> > > In fact, I suspect this change adds a race,
> > ...
> > 
> > His description was right (thanks), so this patch reverts #1.
> > 
> > Signed-off-by: Jarek Poplawski <jarkao2@xxxxx>
> 
> Oleg,
> 
> I think maybe you could ack these 2 netconsole patches...
> They were done on your request but it looks like Andrew
> is waiting on something...

I plan to apply this patch, don't worry about it :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/