Re: Linux 2.6.22-rc7

[Ingo Molnar]

* Christoph Lameter <clameter@xxxxxxx> wrote:

> On Tue, 3 Jul 2007, Ingo Molnar wrote:
> 
> > yeah. Your change looks good to me. You could add a 
> > local_irq_enable_in_hardirq() to the original place, that will map 
> > to a local_irq_enable() on non-lockdep kernels and will be a NOP on 
> > lockdep kernels. (This is a bit hacky though.)
> 
> Then kernels with lockdep would spew out lots of messages later in 
> boot because kmem_cache_init disabled interrupts for good.

no, it would/should result in exactly the same kernel image and lockdep 
behavior as with your current patch. (but when lockdep is disabled in 
the .config then interrupts are enabled earlier on.) Not a big issue, 
just noted this possibility.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/