Re: [v4l-dvb-maintainer] [PATCH] se401: fix "&& 0x" typo

[Mauro Carvalho Chehab]

Em Seg, 2007-07-02 Ãs 15:04 +0400, Alexey Dobriyan escreveu:
> Code there survived trivial regexp made earlier, but after bulk preprocessing
> was done...
> 
> ===>	if (!cp[2] && 0x40) {	<===
> 		printk("<3>" "%s: " "Bayer format not supported!" ...
> 		return 1;
> 	}
> 
> 
> NOTE: to me, check or error message should be reverted, but I know nothing
> about this driver.

Your patch looks to be coherent. However, I suspect that this will break
the driver. There are some functions at the driver for decoding Bayer
format. Without your patch, the if condition will never occur. So, Bayer
decoding will work. 

IMO, the better is to add an #if 0 at the test.

-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/