Re: [PATCH] cross-architecture ELF clean up

[Jeremy Fitzhardinge]

Sam Ravnborg wrote:
> Grouping related things together is always a good approach. But the right
> factor should be used for the grouping. For the ELF file is would from a usage
> perspective be natural to have constants close to the definition that
> they are used to describe. Having constants grouped with other constants just
> _because_ they are constants does not cut here.

Many ELF constants are used without direct reference to their 
corresponding structures.  My linux/elf-const.h header is just a 
generalization of the existing linux/elf-em.h header, which just 
contained the ELF EM_* constants.  Given that there seems to be a 
preexisting need for the EM_* constants in a separate header, and having 
a separate elf-*.h for each group of constants is a bad idea, it seemed 
to me that elf-const.h was the appropriate direction to take.

   J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/