Re: [patch] CFS scheduler, -v18

From: Ingo Molnar
Date: Sun Jul 01 2007 - 04:45:41 EST



Willy,

could you check whether your current v18 CFS tree has the fix below
included? I discovered it right after having released v18 so i updated
the v18 files in place - but maybe you downloaded an early version? I
thought it's relatively harmless, that it would only affect SCHED_IDLE
tasks, but maybe it affects nice +19 tasks too on your box!

Ingo

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -342,8 +342,9 @@ update_stats_enqueue(struct cfs_rq *cfs_
s64 tmp;

if (se->wait_runtime < 0) {
- tmp = (0 - se->wait_runtime) << NICE_0_SHIFT;
- key += (tmp * se->load.inv_weight) >> WMULT_SHIFT;
+ tmp = -se->wait_runtime;
+ key += (tmp * se->load.inv_weight) >>
+ (WMULT_SHIFT - NICE_0_SHIFT);
} else {
tmp = se->wait_runtime * se->load.weight;
key -= tmp >> NICE_0_SHIFT;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/