Re: [PATCH 1/3] [PATCH i386] during VM oom condition, kill all threads in process group

From: Anton Blanchard
Date: Thu Jun 07 2007 - 19:21:13 EST



Hi,

> zap_other_threads() requires tasklist_lock.
>
> If we're going to do this then we should probably create some new function
> (with a better name) which takes tasklsit_lock and then calls
> zap_other_threads().
>
> Does this patch fix any observed-in-the-real-world problem? If so, please
> describe it.

Yeah we have had complaints where threaded apps have only one thread
shot down instead of the entire process. This leaves the application in
a bad state, whereas if it had been killed cleanly the application could
have restarted.

My understanding is that fatal signals should kill all threads in the
group.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/