Re: [PATCH] Re: Linux v2.6.22-rc3

From: Alan Cox
Date: Thu Jun 07 2007 - 18:35:20 EST


On Thu, 7 Jun 2007 13:56:11 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

>
>
> On Thu, 7 Jun 2007, Tejun Heo wrote:
> >
> > Ah.. okay. Now I see what's going on. Jeff, this is another device
> > which doesn't set nsect and lbal to 1 after reset. Gregor, please try
> > the attached patch.
>
> Tejun, since Jeff is apparently traveling this week, and Gregor tested the
> patch successfully (and it looks sane anyway - why in Gods name _would_ we
> care what the initial setting of nsect/lbal is?), can you send this in

Its a sanity check, and if the vendors could get their chips right a good
one, but specs/toilet paper usual story

> with the changelog and sign-off?
>
> Maybe it can go through Andrew like the other patch (the sata_promise
> irq/polling handling), but I can take it directly too. Whatever seems
> best.

I'll certainly ACK it, and it also means I can drop a pending patch to
handle the IT8212 raid mode which also gets this wrong.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/