Re: [RFC] [Patch 4/4] lock contention tracking slimmed down

[Martin Peschke]

Ingo Molnar wrote:
> * Martin Peschke <mp3@xxxxxxxxxx> wrote:
>
> > - lock_time_inc() vs. statistic_add_util()
>
> please fix the coding style in lib/statistic.c. It's full of:
>
> {
>         unsigned long long i;
>         if (value <= stat->u.histogram.range_min)
>                 return 0;
>
> put a newline after variable sections.
>
> and:
>
>         on_each_cpu(_statistic_barrier, NULL, 0, 1);
>         return 0;
>
> preferably use a newline before 'return' statements as well. (this is 
> not always necessary, but in the above case it looks better)

Will do (in my local tree, for the time being).

Good points. Thnaks for reviewing.


	Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/