Re: [PATCH -rt] Fix TASKLET_STATE_SCHED WARN_ON()

[john stultz]

On Wed, 2007-06-06 at 11:45 +0200, Ingo Molnar wrote:
> * john stultz <johnstul@xxxxxxxxxx> wrote:
> 
> > This fix avoids this race by making sure *after* we've locked the 
> > tasklet that the STATE_SCHED bit is set before adding it to the list.
> > 
> > Does it look ok to you?
> 
> ah - nice!! What would be the worst-case effect of this bug? (besides 
> the WARN_ON()?) In any case, this fix will be in -rt10. Great work!

The only side effect I can come up w/ is you might run a tasklet 3 times
if it was only scheduled twice.

thanks
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/