Re: [patch] CFS scheduler, -v15

[Ingo Molnar]

* Srivatsa Vaddagiri <vatsa@xxxxxxxxxx> wrote:

> > i'm pleased to announce release -v15 of the CFS scheduler patchset.
> 
> Do I smell a bug when a task switches its scheduling classes?
> 
> Lets say a task was in real-time class for a long time and switches to 
> fair-sched class. When update_curr() is called on this new fair-sched 
> task, some of required fields (for ex: exec_start) are uninitialized 
> and can lead to bogus calculations?

yep, you are right. Dmitry Adamushko and Balbir Singh are working on 
this area, and my tree already contains the fixes for rt task's 
exec_start. (this also gives us the ability to have precise 'top' 
statistics for RT tasks.) So this should be fixed in -v16. (Since it's 
quite uncommon for a task to drop in and out of scheduling classes, this 
problem was found via review, not via any user-visible regression.)

> Also, real-time tasks are currently influencing fair clock 
> calculations (because there is only one raw_weighted_load field per 
> runqueue). Is that intentional?

yep - the 'fair clock' in essence freezes when RT tasks are running (but 
not completely). Can you think of any bad effect from this perhaps? It's 
useful to have unified load-balancing (smpnice-driven) between the RT 
and fair classes.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/