Re: [PATCH] lguest-fix-divide-error-implement-sched_clock

From: H. Peter Anvin
Date: Tue Jun 05 2007 - 12:16:32 EST


Andrew Morton wrote:
> On Tue, 5 Jun 2007 16:24:52 +0200 Andi Kleen <ak@xxxxxxx> wrote:
>
>> On Tuesday 05 June 2007 15:11, Rusty Russell wrote:
>>> On Tue, 2007-06-05 at 12:01 +0200, Andi Kleen wrote:
>>>>> But TSC is a "required feature", so "cpu_has_tsc" is always true.
>>>> Hmm? It isn't. What makes you think so?
>>> Interestingly it seems to be only in -mm.
>> If it is then it doesn't come out of my tree. Also sounds broken to me.
>> The required bits are only for features needed by the compiler's generated
>> code where not having them could cause an early crash.

Yes. Since there is now a mechanism to get a clean message out, it
seemed like a good idea to extend the benefit of static determination.
Andi already had in his tree -- and I copied it -- code to deal with
stuff like "cpu_has_tsc" as a compile-time constant, eliminating the
"else" clause.

Depending on the configuration it affects FPU, TSC, 3Dnow.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/