Re: [PATCH ext3/ext4] orphan list check on destroy_inode

[Andrew Morton]

On Mon, 04 Jun 2007 09:18:55 +0400 Vasily Averin <vvs@xxxxx> wrote:

> Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue.
> 
> Signed-off-by:	Vasily Averin <vvs@xxxxx>
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 6e30629..46e2fa6 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -459,6 +459,21 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
>  
>  static void ext3_destroy_inode(struct inode *inode)
>  {
> +	if (!list_empty(&(EXT3_I(inode)->i_orphan))) {
> +		int i, imax;
> +		unsigned int *p;
> +
> +		p = (unsigned int *)EXT3_I(inode);
> +		imax = sizeof(struct ext3_inode_info) / sizeof(unsigned int);
> +		printk("Inode %p: orphan list check failed!\n", EXT3_I(inode));
> +		for (i = 0; i < imax; i++) {
> +			if (i && ((i % 8) == 0))
> +				printk("\n");
> +			printk("%08x ", *p++);
> +		}
> +		printk("\n");
> +		dump_stack();

umm, OK, but please use the new lib/hexdump.c for this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/