Re: [ATA]: Don't allow to enable this for SPARC64 without PCI.

[Jeff Garzik]

On Mon, Jun 04, 2007 at 08:59:06PM +0000, Linux Kernel Mailing List wrote:
> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=899b69d079713d0f568fb2700b86987aa94f29b2
> Commit:     899b69d079713d0f568fb2700b86987aa94f29b2
> Parent:     e11a6c236b3070ed05b079f91a9b3defa48b54d3
> Author:     David S. Miller <davem@xxxxxxxxxxxxxxxxxxxx>
> AuthorDate: Sun Jun 3 17:39:56 2007 -0700
> Committer:  David S. Miller <davem@xxxxxxxxxxxxxxxxxxxx>
> CommitDate: Sun Jun 3 18:09:42 2007 -0700
> 
>     [ATA]: Don't allow to enable this for SPARC64 without PCI.
>     
>     Based upon a report from Meelis Roos.
>     
>     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> ---
>  drivers/ata/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index b4a8d60..7d893a6 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -8,6 +8,7 @@ menuconfig ATA
>  	depends on BLOCK
>  	depends on !(M32R || M68K) || BROKEN
>  	depends on !SUN4 || BROKEN
> +	depends on !(SPARC64 && !PCI)
>  	select SCSI

Um, this was NAK'd:

libata uses generic DMA and generic struct device.  Neither of which
are specific to SPARC64 or PCI.

Did you read the code?
Did you read the thread on which you were CC'd?
Did you see the NAKs from me and Alan (and others)?

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/