2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

From: Adrian Bunk
Date: Sat Jun 02 2007 - 13:14:31 EST


statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch
shows why __attribute__((weak)) is harmful because you don't see if a
required non-weak implemtation is missing:

In this case, the weak printk_clock() was renamed to timestamp_clock(),
but the ARM and i386 implementations weren't renamed...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/