Re: [PATCH 1/7] cxgb3 - Fix SGE page management

[Divy Le Ray]

Jeff Garzik wrote:
> divy@xxxxxxxxxxx wrote:
> > From: Divy Le Ray <divy@xxxxxxxxxxx>
> >
> > Streamline page management on RX.
> > Fix dma mappings.
>
> NAK #2:  You should use the page_address(page) accessor rather than 
> creating a struct member in the same struct as your page, solely to 
> contain the virtual address.
Jeff,

The struct member caches the value of page_address(page) + current 
offset for optimization purposes.

Divy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/