Re: [PATCH] [RAMFS NOMMU]: a bug in ramfs_nommu_resize function,passing old size to vmtruncate

From: Bryan Wu
Date: Wed May 30 2007 - 23:36:28 EST


On Thu, 2007-05-31 at 11:31 +0800, Bryan Wu wrote:
> It should be pass "newsize" to vmtruncate function to modify the
> inode->i_size,
> while the old size is passed to vmtruncate.
>
> This bug was catched by LTP truncate test case on Blackfin platform.
> After it was fixed, the LTP truncate test case passed.
>
> Signed-off-by: Bryan Wu <bryan.wu@xxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> ---
> fs/ramfs/file-nommu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c
> index 3b481d5..9345a46 100644
> --- a/fs/ramfs/file-nommu.c
> +++ b/fs/ramfs/file-nommu.c
> @@ -179,7 +179,7 @@ static int ramfs_nommu_resize(struct inode *inode, loff_t newsize, loff_t size)
> return ret;
> }
>
> - ret = vmtruncate(inode, size);
> + ret = vmtruncate(inode, newsize);
>
> return ret;
> }

David:

Sorry for sending this email several times , my git-send-email got some
problem.

Thanks
-Bryan Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/