Re: [PATCH] add a trivial patch style checker

From: Randy Dunlap
Date: Wed May 30 2007 - 11:32:57 EST


Jan Engelhardt wrote:
On May 29 2007 15:36, Randy Dunlap wrote:
+ if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){
+ print "Gotos should not be indented\n";
+ print "$herecurr";
+ $clean = 0;
+ }
emacs generates one space label in front of a goto label. I wouldn't
outlaw this.
Yep, we also now allow one space something to do with diff -p not
getting confused...
Not only diff and emacs. At least joe (joe.sf.net) is another editor
[...]
That's just a joe bug then.

diff no longer requires a beginning space, at least in the testing
that I did it worked with no leading space on a label:.

But not everyone runs the latest and greatest. diffutils 2.8.7
takes /^label:/ as a marker for the @@ line.

OK. What does "marker for the @@ line" mean?

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/