Re: [PATCH 0/6] lock contention tracking -v4

From: Ingo Molnar
Date: Wed May 30 2007 - 09:18:34 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> Changes since -v3
> - reshuffled code to reduce #ifdef mess

| Now at patch patches/raw_spinlock_fix.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 17

ok, this is unmodified lockdep.c.

| # quilt push
| Applying patch patches/lockdep-prove-locking.patch
| patching file kernel/lockdep.c
| patching file kernel/spinlock.c
|
| Now at patch patches/lockdep-prove-locking.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 23

this was the increase that Christoph commented on.

| # quilt push
| Applying patch patches/lockdep-reduce-ifdefs.patch
| patching file kernel/lockdep.c
| patching file kernel/lockdep_proc.c
|
| Now at patch patches/lockdep-reduce-ifdefs.patch
| # grep "#ifdef" kernel/lockdep.c | wc -l
| 11

and now it's lower than where it started out and you also put lockstat
in! Nice! :)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/