Re: [PATCH] x86: fix section mismatch warnings in mtrr

From: Indan Zupancic
Date: Sat May 26 2007 - 08:07:43 EST


On Mon, May 21, 2007 17:11, Sam Ravnborg wrote:
> On Mon, May 21, 2007 at 02:52:39PM +0100, Jeremy Fitzhardinge wrote:
>> Sam Ravnborg wrote:
>> > There was another patch that removed the __init marker to _fix_ section mismatch errors.
>> > I have lost the actual mail but I asked the submitter to send me a copy of
>> > the configuration so I could take a closer look.
>> > Obviously it was the wrong fix to remove the _init marker.
>>
>> Hm, I think there were two overlapping patches to address the problem.
>> One removed the __init markers, and was a bit of a hack. Mine
>> restructured all the functions so that it was all done properly (ie,
>> init called init; cpuinit called cpuinit). Looks like both got applied.
>
> OK, then all is good.

Did the patches reach 2.6.22-rc3 yet?

If they did, then the following warnings might need fixing:

WARNING: arch/i386/kernel/built-in.o(.text+0x84bc): Section mismatch: reference to
.init.text:amd_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x84c1): Section mismatch: reference to
.init.text:cyrix_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x84c6): Section mismatch: reference to
.init.text:centaur_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x92d8): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')
WARNING: arch/i386/kernel/built-in.o(.text+0x92ef): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')
WARNING: arch/i386/kernel/built-in.o(.text+0x9313): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')

Config attached.

Greetings,

Indan

Attachment: config.gz
Description: application/gzip