Re: Multiple free during oprofile unload

[Dave Jones]

On Fri, May 25, 2007 at 05:42:35PM +0200, Andi Kleen wrote:
 > 
 > >         for_each_possible_cpu(i) {
 > >                 kfree(cpu_msrs[i].counters);
 > >                 cpu_msrs[i].counters = NULL;
 > >                 kfree(cpu_msrs[i].controls);
 > >                 cpu_msrs[i].controls = NULL;
 > >         }
 > > 
 > > Seems the patch makes all the cpu_msrs[] point to the same area?
 > 
 > Yes I forgot to fix the free path. Will submit a patch.
 > 
 > BTW that is why I'm not so happy with you being so trigger happy with stable
 > submissions.

So what, the alternative is leave oprofile busted in 2.6.21.x even longer?

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/