Re: [patch] sched_clock(): cleanups

[Ingo Molnar]

* Satyam Sharma <satyam.sharma@xxxxxxxxx> wrote:

> Hi Ingo,
> 
> On 5/25/07, Ingo Molnar <mingo@xxxxxxx> wrote:
> >[...]
> >@@ -137,6 +147,7 @@ static void call_r_s_f(void *arg)
> > {
> >        struct cpufreq_freqs *freq = arg;
> >        unsigned f = freq->new;
> >+
> >        if (!f)
> >                f = cpufreq_get(freq->cpu);
> >        if (!f)
> 
> if (!f)
> 	f = cpufreq_get(freq->cpu);
> if (!f)
> 	f = tsc_khz;
> 
> ?
> 
> Something's not quite right here :-)

yeah, that looks like a real bug. When i looked at it during the cleanup 
i guess i got distracted by the descriptive function name of 
call_r_s_f() ... :-/

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/