Re: [PATCH 2/4] AFS: Add a function to excise a rejected write from the pagecache
From: David Howells
Date: Thu May 24 2007 - 19:38:00 EST
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> But we already covered that? Your exciser can do an unconditional
> end_page_writeback(), because it is this thread of control which did the
> set_page_writeback(). So we end up with:
Ah, I misunderstood what you meant. I assumed you meant to wait insted of
ending.
Of course, if we've decided to excise this page, it really oughtn't to get
PG_writeback set again. I'll have to think about that.
> Well someone needs to be taught all about this case. Question is, should
> it be the VFS, or should it just be the address_space(s) which brought
> this state about, and which care about it?
For the most part, I think that this only applies to netfs's, and possibly not
all of those, so making it fully general might be overkill.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/