Re: [PATCH 3/7] lockdep: lock contention tracking

[Jason Baron]

On Wed, 23 May 2007, Peter Zijlstra wrote:

> Count lock contention events per lock class. Additionally track the first four
> callsites that resulted in the contention.
> 

I think that we need the total number of locking calls, not just the total 
number of *contended* locking calls, in order to make the data 
significant. Same for waittime. Yes, this pollutes the fastpath. In the 
contention case, its one extra addition, and for the waittime, its a call 
the sched_clock(). I don't think that's too much to pay for much more 
meaningful data.

thanks,

-Jason
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/